QuickNovel icon indicating copy to clipboard operation
QuickNovel copied to clipboard

Add Archive of our own Provider

Open PrecociouslyDigital opened this issue 1 year ago • 19 comments

PrecociouslyDigital avatar Jun 07 '23 04:06 PrecociouslyDigital

It's done and ready for merge on my end!

PrecociouslyDigital avatar Jun 12 '23 05:06 PrecociouslyDigital

dont do too much UI as all UI is currently being refacored

LagradOst avatar Jun 19 '23 21:06 LagradOst

dont do too much UI as all UI is currently being refacored

What part of the UI are you referring to? the login system?

PrecociouslyDigital avatar Jun 19 '23 21:06 PrecociouslyDigital

dont do too much UI as all UI is currently being refacored

What part of the UI are you referring to? the login system?

yup

LagradOst avatar Jun 19 '23 21:06 LagradOst

Unfortunately it needs some UI so the user can enter their username and password to access protected works on AO3; The total extent of this is just a setting in the settings menu.

PrecociouslyDigital avatar Jun 19 '23 21:06 PrecociouslyDigital

Unfortunately it needs some UI so the user can enter their username and password to access protected works on AO3; The total extent of this is just a setting in the settings menu.

yes, just dont add anything extra

LagradOst avatar Jun 19 '23 21:06 LagradOst

It's ready for review/merge now

PrecociouslyDigital avatar Jun 19 '23 21:06 PrecociouslyDigital

An app wide cookie jar makes everything harder to debug and handle. Easier for us to be explicit with cookies for deterministic behavior.

If you want sessions with cookies I think https://github.com/Blatzar/NiceHttp/blob/master/library/src/main/java/com/lagradost/nicehttp/Session.kt would work good enough for limited time cookies.

At the very least please create your own cookie requests instance instead of an app wide change.

LagradOst avatar Jun 24 '23 22:06 LagradOst

do note that I removed the cookejar from mainactivity

LagradOst avatar Jul 02 '23 17:07 LagradOst

ready for review!

PrecociouslyDigital avatar Jul 02 '23 19:07 PrecociouslyDigital

@PrecociouslyDigital I tried the ao3 provider and tried to log in using the new provider settings, and it just crashed. also the search timed out.

KillerDogeEmpire avatar Jul 04 '23 16:07 KillerDogeEmpire

  1. DONT USE A FRAGMENT. use an alert
  2. Your current code is crashing
  3. Archive of our own Provider is reporting ratings higher than possible in qn you are confusing the variables, read https://github.com/LagradOst/QuickNovel/blob/3253fbdc4f5a4666669d3c5845d4e2f5d235cb40/app/src/main/java/com/lagradost/quicknovel/MainAPI.kt#L201 or just do peopleVoted = peopleVoted views = views ect
  4. You use MainActivity.mainActivity everywhere, use context instead as it is a global weak reference or even activity if activity is needed

LagradOst avatar Jul 05 '23 16:07 LagradOst

@LagradOst I'd like to clarify; I shouldn't make provider settings a menu of its own?

PrecociouslyDigital avatar Jul 05 '23 19:07 PrecociouslyDigital

@LagradOst I'd like to clarify; I shouldn't make provider settings a menu of its own?

shit forgor to reply, but I want to show an Alert for settings, it is a sort of popup so you dont take up the entire page. Here is an example in cs3. This also makes it possible to show anywhere image

LagradOst avatar Jul 10 '23 00:07 LagradOst

Gotit; I unfortunately will be busy until August so if you or anyone else wants to make these changes I'd be delighted. If not I'll try to get this in by Aug 15th

PrecociouslyDigital avatar Jul 12 '23 23:07 PrecociouslyDigital

Understandable, have a great day

LagradOst avatar Jul 13 '23 00:07 LagradOst

@PrecociouslyDigital this still in progresss, if not I'll try my best to finish it. I was going to add it ages ago since I wanted to add this for my crush

KillerDogeEmpire avatar Dec 07 '23 06:12 KillerDogeEmpire

This is no longer in progress sorry. Feel free to use it as a starting point. Iirc every thing but logging in works.

On Wed, Dec 6, 2023, 22:21 Sir Aguacata @.***> wrote:

@PrecociouslyDigital https://github.com/PrecociouslyDigital this still in progresss, if not I'll try my best to finish it. I was going to add it ages ago since I wanted to add this for my crush

— Reply to this email directly, view it on GitHub https://github.com/LagradOst/QuickNovel/pull/173#issuecomment-1844691659, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCZPZKYJOR2W2NGOGMKSY3YIFN6XAVCNFSM6AAAAAAY5JQCUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBUGY4TCNRVHE . You are receiving this because you were mentioned.Message ID: @.***>

PrecociouslyDigital avatar Dec 07 '23 06:12 PrecociouslyDigital

please add local source @LagradOst

cheesy3097 avatar Apr 27 '24 06:04 cheesy3097