Wei
Wei
Could you please squash the second commit into the first one to keep the commit history clean? Everything will look good to me once that's done. Thanks!
ACK 8374f70b3428870a0ef5f77278329897464fee88
ACK 7c3f915886881c7d50e7f02eaef2774e63d1a3dc
ACK 056f26ca611399512964bd69240e98c6f190845b
Hi @torkelrogstad , just checking in on this one since it’s been quiet for a while. Do you still need `tracing` support for your use case? Or was it mainly...
Yeah, I’m personally in favor of adding `tracing` (behind a feature flag) — not for full coverage, but just to give users more visibility into what’s going on under the...
> What was the discussion around breaking changes? Were we okay to break the API? Iirc the consensus was for this to be a breaking change to be a cleaner...
> I've started experimenting with my suggestion in [#1582 (comment)](https://github.com/bitcoindevkit/bdk/pull/1582#issuecomment-3214838670). > > This is the WIP commit: [evanlinjin@8f374cc](https://github.com/evanlinjin/bdk/commit/8f374ccb639e98836b482d3cb0e704ec64f50aa1). I'm quite happy with the implementation of it (unless proven otherwise). >...
> Since this doesn't touch the wallet APIs I moved it to the beta milestone. I'm okay with this!
Hello! What kind of responsibilities would these "other components" typically have in this context? (e.g., relying on confirmation status for rebroadcasting transactions, indexing txs, etc.) Just trying to better understand...