Mortal dysmorphia may not kill if the players involved have >100 max HP

[James103]

Mortal dysmorphia always deals 100 HP of damage upon turning mortal if the soul does not belong in the body it's inhabiting; this amount is regardless of the player's max health. https://github.com/Ladysnake/Requiem/blob/5fd09888475e9be2ed8735f3b172b5d0a24df37b/src/main/java/ladysnake/requiem/common/VanillaRequiemPlugin.java#L249

The 100F constant should be changed to player.getMaxHealth() * 5 to ensure the damage source always hits for an amount greater than the player's max health. The damage source itself may need to be changed to act like void damage instead of just magic, further ensuring no amount of protection can reduce the damage amount below the player's max health.

[PsychoBreadstick]

I was testing this issue, another thing to keep in mind is that the damage would have to bypass totems of undying since those do also allow the issue to persist.

[kristibektashi]

I was testing this issue, another thing to keep in mind is that the damage would have to bypass totems of undying since those do also allow the issue to persist.

Void damage already bypasses totems

[PsychoBreadstick]

I was unaware of that, thank you.

[kristibektashi]

I was unaware of that, thank you.

As of 1.20.1 there is a new generic_kill damage type that afaik bypasses all damage reductions