LadybirdBrowser
LibWeb/CSS: Implement 5.3.4: The effect value of a keyframe effect
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
With counting the regressions in this change passes +7 tests, I'll see if I can reduce the regressions.
EDIT: +13 wpt tests
Thanks @Calme1709 for the thorough review, really helps me to understand more of the coding style of the project.
I've addressed all your comments.
(Also I hope I didn't step any toes implementing this.. It's not fun to work on a feature and see a PR appear suddenly implementing the exact same thing 😀)
Thanks for the review, sorry for being a bit hasty in resolving your comments. I didn't fully follow your instructions previously, especially for the comment formatting, apologies for that and thanks for your patience. If I still missed something, just let me know :)
I also note that we have two commits in this PR, could you please squash them into one?
Done!
I imported some of the passing WPT tests. (The import script seems to crash sometimes? Is this known or maybe it's something on my end?)
Thanks @Calme1709, for your time and the guidance here. This really helps for my future PRs to have a smoother review experience. 🙏
Should I advertise the PR for maintainers or will they pick it up once they have time?
Of course! Glad to have you working on the project!
Usually a maintainer will pick it up when they get a change but if you don't have any activity in a few days feel free to drop a message in the #code-review channel in Discord.
Only tiny things, this looks good to me otherwise. 👍
Thanks for the prompt review! I addressed your comments.
@AtkinsSJ, the test that was imported was a flaky pass that I happened to import, it had nothing to do with these changes. Could I request another CI run? Thanks!
(It was about background-image overwriting background-color and in ladybird sometimes the background color shows right before the image)
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.