ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

LibWeb: Clamp cursor position in click handling

Open vpzomtrrfrt opened this issue 1 year ago • 4 comments

Should fix #529

vpzomtrrfrt avatar Jul 10 '24 05:07 vpzomtrrfrt

seems like it's still not fully solved, no crashes but it sometimes won't let me type anything

vpzomtrrfrt avatar Jul 11 '24 00:07 vpzomtrrfrt

which isn't a new issue, as I mentioned in #529

when that happens, the cursor position node is an element inside a document fragment, whereas the working case has it as a text node

vpzomtrrfrt avatar Jul 11 '24 02:07 vpzomtrrfrt

looks like it's triggered by dragging when selecting the input field

vpzomtrrfrt avatar Jul 11 '24 02:07 vpzomtrrfrt

There has been quite a few changes in this area, namely: #2024 which deletes EventHandler.cpp I can no longer reproduce the crash in #529.

rgret-dev avatar Dec 07 '24 14:12 rgret-dev

The issue is still present, though yes this PR no longer really applies

vpzomtrrfrt avatar Dec 23 '24 16:12 vpzomtrrfrt