ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

AK: Resolve FIXME in Windows implementation of demangle()

Open tomaszstrejczek opened this issue 9 months ago • 1 comments

This implements demangle() using Windows API. Also some rudimentary test is provided.

tomaszstrejczek avatar Jun 04 '25 18:06 tomaszstrejczek

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

ladybird-bot avatar Jun 04 '25 18:06 ladybird-bot

Maybe we can pull in llvm demangle? It is fully self contained, and uses only std, not the llvm types.

R-Goc avatar Jun 05 '25 21:06 R-Goc

Maybe we can pull in llvm demangle

Certainly not. Like I said, we only use this for debugging purposes. Performance of demangling is not a concern. Memory usage is not a concern. The thing that matters is not affecting normal release builds where we never hit this code path.

ADKaster avatar Jun 06 '25 02:06 ADKaster

Didn't even think about perf here. It's header only and allocates its buffer. Seems like the sanest api to use. If not then we should make the buffer big. Like 4k or similar.

R-Goc avatar Jun 06 '25 06:06 R-Goc