ladybird
ladybird copied to clipboard
AK/LibJS/LibCrypto: implement random for Windows
This commit implements a high quality randomness source for AK/Random. This avoids the fallback to rand(). The LibJS math xoshiro128+ prng is now seeded with SecureRandom. A convenience get_secure_random method was added to SecureRandom to directly construct the requested type.
Hello!
One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.
ASAN not complaining is encouraging but I don't think the fallback which I'm worried about actually has any code coverage.
I also wonder if marking advance in xorshift always inline along with get wouldn't be useful.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
unstale