LadybirdBrowser
LibWebView: Added 4get search engine
Hello!
One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.
I'm not sure why the linter still fails here, might be due to the double name change :x
I'm not sure why the linter still fails here, might be due to the double name change :x
What's happened is that you still have the original commit here which the linter doesn't like, you just also have a couple of other commits with the corrected name. https://www.youtube.com/watch?v=ElRzTuYln0M might be helpful, it explains how to modify past commits and rearrange them and such. Ideally you would just have the one commit, with the change and the "good" commit message.
As for the change itself, I appreciate why you'd want to be able to use your own search engine by default, but it doesn't seem a good fit for adding to Ladybird. I think what we really want is the ability for users to customize the search engines themselves, like you can in other browsers. Then you and everyone else who uses 4get (or other smaller-scale engines) would be able to use their favourite instance of it, without adding every server from https://4get.ca/instances in here. :^)
Sweet!! It would be nice if it could support opensearch as well (a.k.a adding a search engine through right clicking the URL bar)