ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

LibWeb: Implement view transitions

Open Psychpsyo opened this issue 1 year ago • 1 comments

This implements the CSS view-transitions-1 spec.

Opening this as a draft so people can look at it if they want to, and to link to it in various other bug reports.

Psychpsyo avatar Mar 23 '25 11:03 Psychpsyo

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

github-actions[bot] avatar Mar 25 '25 23:03 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Apr 16 '25 02:04 github-actions[bot]

This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions!

github-actions[bot] avatar Apr 24 '25 02:04 github-actions[bot]

@Psychpsyo is there any part of this that can be chunked up into mergable commits?

ADKaster avatar Apr 24 '25 16:04 ADKaster

@Psychpsyo is there any part of this that can be chunked up into mergable commits?

I started on that with https://github.com/LadybirdBrowser/ladybird/commit/ad0da8ffa39611264948ae2c5fc61b7483104009 a while back. That one is a pre-requisite for any further work here. (Ran into a SEGFAULT there and debugging it was tedious enough for me to put it aside for a while. Would love help but also feel bad about just making it someone else's problem.)

Though technically the stuff in here could be merged with some small changes right now, it just wouldn't be a sensible or useful amount of feature.

It needs a bit more work plus that other commit to be in a state where an invisible view transition can be started and actually ends on its own.

After that, more stuff can comfortably be in its own PRs

Psychpsyo avatar Apr 24 '25 21:04 Psychpsyo

Sounds good; So we can leave this PR closed without any work getting super lost?

ADKaster avatar Apr 24 '25 21:04 ADKaster

Sounds good; So we can leave this PR closed without any work getting super lost?

My plan was to re-open it once I got that other commit figured out. This PR was a draft before being closed anyways.

Psychpsyo avatar Apr 24 '25 21:04 Psychpsyo