ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

Nix: Remove duplicate `shell.nix`

Open ttrssreal opened this issue 8 months ago • 3 comments

If we really want we can introduce a compatibility layer, but flakes are pretty standard.

ttrssreal avatar Mar 19 '25 16:03 ttrssreal

I know nothing about Nix, but this only got added a couple of weeks ago in #3767. It feels a bit like every Nix user has a different way of doing things. :sweat_smile:

cc: @NotAShelf Can we come to some kind of agreement for Nix?

AtkinsSJ avatar Mar 20 '25 17:03 AtkinsSJ

This is not about different ways of doing things, but about what "versions" of Nix would you like to support. shell.nix is an artifact of older, "legacy" (very heavy quotes here) nix2 and a flake.nix is the newer, shinier nix3. They are two different hills people to die on, but a majority of Nix consumers use flakes- the ideological arguments against flakes are mostly from the more technical part of the community. I, for one, welcome flakes, albeit with their flaws.

On this PR, I'm fully in favor. nix3 (flakes) enforces better idioms, and as @ttrssreal stated they are pretty standard. Removing the top-level shell.nix removes the legacy (nix2) interface, but retains the shell.nix I have added in the toolchain directory that is called from the flake. Should nix2 compatibility become a problem, there are clean solutions that we may choose to apply as necessary.

If there is anything specific you would like my input on, I am happy to provide.

NotAShelf avatar Mar 20 '25 17:03 NotAShelf

Don't mean to stir drama :3 Either way we shouldn't have 2 shell.nix's, like @NotAShelf says theres solutions if it becomes an issue

ttrssreal avatar Mar 20 '25 18:03 ttrssreal

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

github-actions[bot] avatar Mar 24 '25 17:03 github-actions[bot]

This is outdated now that Nix support has been removed from the repository. Closing.

gmta avatar Mar 24 '25 17:03 gmta