ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

Tests: Do not use data URI in css-mask-longhand test

Open pixelspark opened this issue 9 months ago • 3 comments

Instead use an existing image and ensure it loads to prevent flakiness (due to #3448)

pixelspark avatar Mar 05 '25 21:03 pixelspark

In order for this test to actually run, you will have to include a revert of 292b566b9fa6a63dfca9e9ed90151e591a6f8389 in this PR.

trflynn89 avatar Mar 06 '25 14:03 trflynn89

Thanks @trflynn89 and @InvalidUsernameException for your feedback, I will adress both suggestions (hopefully this weekend).

pixelspark avatar Mar 07 '25 12:03 pixelspark

OK, this should do it!

pixelspark avatar Mar 08 '25 08:03 pixelspark

Thanks! I've rerun CI for this a few times to see if the test flakes at all, and I haven't seen any :crossed_fingers:

trflynn89 avatar Mar 11 '25 16:03 trflynn89