ladybird
ladybird copied to clipboard
Meta: Update devcontainer
While trying to run the dev container, I faced a few issues:
- the packages were outdated
- some needed packages were missing
This includes the following:
In Ubuntu 20.04 (jammy) we don't have the minimum CMake version of 3.25, we could add it by using the kitware apt repo or by using the newer LTS (See below)
Some packages, that are needed for them to be compiled by vcpkg are missing, they were added to Documentation/BuildInstructionsLadybird.md but not to the devcontainer install.sh script. e.g. libavformat-dev or nasm.
Also jammy is the older LTS, the newer LTS noble (22.04) is already out by a half year, so using the newer mcr.microsoft.com/devcontainers/base image is a good idea. The official apt repos for llvm also support llvm 19 (see here) So I added this to the suggestion, so that everyone is aware, that it already works (personally I already switched to llvm 19, also while working on ladybird, but it's using llvm 18 everywhere else, so I kept that)
devcontainer.json also supports a customizations files, so I added the recommended extensions and settings there too, taken from Documentation/VSCodeConfiguration.md I find it easier, to have those in there, as it really helps.
you rebuild it
Except the update to noble for the never CMake (which we also could theoretically do with the kitware repo) and the addition of the new packages, everything is optional, but I find it a good idea and it follows repos conventions :)
I tested the devcontainer locally and it works perfectly now :)
A general note, to those who never worked with devontainers, everything that is installed manually after booting it up, gets removed (the container gets reset) when you rebuild it, so having more in there is a better idea, since uninstalling something is way easier, then manually installing the correct thing :)