LabSound icon indicating copy to clipboard operation
LabSound copied to clipboard

LOG_PRINT should replace ASN_PRINT, printf, and std::iostream

Open raub opened this issue 1 year ago • 4 comments

This is probably from debugging: https://github.com/LabSound/LabSound/blob/v1.2.0/src/core/AudioNode.cpp#L20

A similar log is currently in main: https://github.com/LabSound/LabSound/blob/main/src/core/AudioNode.cpp#L19

Also, why not use LOG_TRACE or some of those?

raub avatar Nov 18 '23 17:11 raub

It's historic. ASN_PRINT is very old, and should have been moved when LOG_TRACE was introduced. I hadn't thought about that point.

meshula avatar Nov 18 '23 21:11 meshula

Well that's currently named LOG_PLAYBACK_STATE_TRANSITION. Switching to LOG_TRACE makes sense.

raub avatar Nov 19 '23 06:11 raub

Also when using loadHrtfDatabase, I get a ton of logs from https://github.com/LabSound/LabSound/blob/main/src/extended/AudioFileReader.cpp#L85 - because printf is used directly.

raub avatar Nov 20 '23 10:11 raub

You've found enough inconsistencies to make this a specific task to clean up all logging and tracing ~ I renamed the issue to be more general.

meshula avatar Nov 20 '23 19:11 meshula