Olof Lagerkvist

Results 117 comments of Olof Lagerkvist

I think it is safe to just return null from `GetRecord()` in these cases. When I investigated it a few years ago I could not find any issues with doing...

Yes, my fork is at http://github.com/LTRData/DiscUtils and nuget packages have the same names as here but with `LTRData.` prefix, for example `LTRData.DiscUtils.Ntfs`. https://www.nuget.org/packages/LTRData.DiscUtils It should be said that there are...

I implemented your changes in my fork now: https://github.com/LTRData/DiscUtils/commit/ca3b9c38e615d3eb3a24ead202ee230a39af28c7 I plan to publish new NuGet packages with this fix soon. Thanks a lot for your contribution! Could you take a...

Okay, sounds like it makes sense. I'll try to figure out how this could be tested in some other way.

Okay, fixed the test case and built new nuget packages. Packages from my fork are prefixed with `LTRData.`, so for example `LTRData.DiscUtils.Iso9660`. Note also that there are some breaking changes...

> .net 8 targets as well for nuget? =) Yes!

> I went back and actually checked; The test was correctly failing and I'm not calculating the boot sectors correctly for hard disk emulation. @LTRData I would advise reverting the...

Having looked more into this, I think that there is some logic missing i `SetBootImage` for harddisk emulation. We would need something corresponding to what mkisofs does here: https://github.com/Distrotech/cdrtools/blob/8adb0d06e070464f13d017b1de7187bf23dacd87/mkisofs/eltorito.c#L374 Also,...

In most cases this is true. However, there are a few things in .NET Framework 4.6.2 that are not in .NET Standard 2.0 that sometimes make the implementation easier and...

I usually target .NET 6 and .NET 7 for libraries these days. .NET 6 is a long term service version and lots of project will stay on that version for...