scRNAseq icon indicating copy to clipboard operation
scRNAseq copied to clipboard

Add a Bunis HSPC data getter

Open LTLA opened this issue 3 years ago • 4 comments

@dtm2451 the time has cometh. Should be as simple as copying one of the other getters to BunisHSPCData.R, renaming the function and changing the path to bunis-hspc.

  • Make sure you set rowdata=TRUE in .create_sce() to get the row data.
  • Add yourself to Authors@R.
  • Add the dataset to inst/extdata/manifest.csv.
  • Add some basic tests to longtests/.

LTLA avatar Jan 30 '21 23:01 LTLA

So, uh, Dr Bunis. Any plans for this, or what?

LTLA avatar Feb 17 '21 05:02 LTLA

Yes yes! Fell off my radar, but it's back on for this week. I'll put something together by the weekend.

dtm2451 avatar Feb 17 '21 19:02 dtm2451

I'm not sure of the best ways to convert from dgT to dgC, but the counts matrix is already dgT right out of https://github.com/LTLA/scRNAseq/blob/a04b20d9e387afdd8da27ea263cd42b35cf2f997/inst/scripts/2.6.0/make-bunis-hspc-data.Rmd#L29.

Might as well add the conversion right around there, no?

dtm2451 avatar Apr 29 '21 06:04 dtm2451

Oh crap, didn't notice that's where it was coming from. Yes, the conversion would be done there. I can do that myself.

LTLA avatar Apr 29 '21 06:04 LTLA