firecrown icon indicating copy to clipboard operation
firecrown copied to clipboard
verified publisher icon LSSTDESC

TwoPoint.calculate_pk fails if first source has, and second source lacks, a PT systematic

Open marcpaterno opened this issue 1 year ago • 3 comments

The code in TwoPoint.calcuate_pk does not handle the two tracers it is given symmetrically; if the first is associated with a source that has a PT systematic, and the second is associated with a source that lacks a PT systematic, it will fail.

marcpaterno avatar Apr 30 '24 18:04 marcpaterno

We should have a test that demonstrates this bug.

marcpaterno avatar Apr 30 '24 18:04 marcpaterno

Reopening the issue to fix the problem on the two_point_refactor branch, which is our (unfortunate) branch name for the branch we are using for bug fixes to the v1.7 version of Firecrown.

marcpaterno avatar May 02 '24 19:05 marcpaterno

Now I'm actually going to re-open the issue. If I click on the right button.

marcpaterno avatar May 02 '24 19:05 marcpaterno

This is fixed on master PR #418, and on the branch for the v1.7.x releases (two_point_refactor, for historical reasonas) by PR #415.

marcpaterno avatar Jun 04 '24 16:06 marcpaterno