CLMM icon indicating copy to clipboard operation
CLMM copied to clipboard

Prepare for new CCL release

Open hsinfan1996 opened this issue 1 year ago • 3 comments

Fix how max supported CCL version is checked to prepare for the new release.

hsinfan1996 avatar Mar 05 '24 07:03 hsinfan1996

Coverage Status

coverage: 100.0%. remained the same when pulling 3a5f3aac660da74ecf95716051162fc9a6bc8de2 on issue/619/Fix_CCL_version_checking into 50876a8e86ece8b2821180ccb201734890368889 on main.

coveralls avatar Mar 05 '24 07:03 coveralls

Note: origin of this issue parse("3") is identical to parse("3.0.0").

hsinfan1996 avatar Mar 05 '24 15:03 hsinfan1996

pyccl 3.0.1 and 3.0.2 are released.

hsinfan1996 avatar Mar 09 '24 04:03 hsinfan1996

Is there a reason you're installing CCL from source? It is available in conda-forge, and much quicker to install that way!

joezuntz avatar Jun 19 '24 12:06 joezuntz

Is there a reason you're installing CCL from source? It is available in conda-forge, and much quicker to install that way!

I think it is partly because we want to check the dev versions, and in the CI script, we don't need to specify what version to install.

hsinfan1996 avatar Jun 19 '24 16:06 hsinfan1996

conda will be broken after installing cmake due to an upstream issue https://github.com/libarchive/libarchive/pull/1976, so I moved up the installation of sphinx prereqs.

hsinfan1996 avatar Jun 19 '24 18:06 hsinfan1996

@hsinfan1996, @m-aguena - I see this morning that you've made further changes here that should work for all CCL v3.x.x, right? Thank you! Is this ready for review/to be merged?

combet avatar Jun 20 '24 08:06 combet

@combet Yes, this is ready for review.

hsinfan1996 avatar Jun 20 '24 09:06 hsinfan1996