CLMM icon indicating copy to clipboard operation
CLMM copied to clipboard
verified publisher icon LSSTDESC

Update required Scipy version

Open hsinfan1996 opened this issue 1 year ago • 3 comments

#615 needs to be merged first in order not to make changes to the CI script.

hsinfan1996 avatar Feb 20 '24 01:02 hsinfan1996

Coverage Status

coverage: 100.0%. remained the same when pulling 298614fd5c04cd1b049687d9930563c407b31f26 on issue/616/scipy_simps_rename into 714b92d9343e19ff0ac9b7555a8c113847e6bbb4 on main.

coveralls avatar Feb 20 '24 16:02 coveralls

@hsinfan1996 is ccl going to require this newer scipy version too?

m-aguena avatar Feb 21 '24 11:02 m-aguena

@hsinfan1996 is ccl going to require this newer scipy version too?

~No, CCL does not depend on scipy. But ccl 3.0.1 is going to be released soon and the current mechanism for checking the version number will fail. I think it is quicker to fix it in this PR. I can do it in a separate PR if it is the proper way.~ Moved to a new PR.

hsinfan1996 avatar Feb 21 '24 11:02 hsinfan1996

integrate.simps has been deprecated and will be removed in Scipy v1.14.

hsinfan1996 avatar Jun 20 '24 18:06 hsinfan1996

There is one more simps here, but I did not change it since it was commented out. https://github.com/LSSTDESC/CLMM/blob/714b92d9343e19ff0ac9b7555a8c113847e6bbb4/clmm/utils/statistic.py#L213

hsinfan1996 avatar Jun 20 '24 19:06 hsinfan1996