CLMM icon indicating copy to clipboard operation
CLMM copied to clipboard

CLMM v2.0 desired features

Open combet opened this issue 3 years ago • 8 comments

This is an issue to discuss what functionalities we'd like to see in CLMM v2.0

combet avatar Jan 19 '22 08:01 combet

Top of my head:

  • [x] Stack analysis (#457, #460, #462)
  • [x] Einasto/Hernquist profiles for CCL backend (#461)
  • [x] 2 halo term (#459 )
  • [ ] Include mass fitting in CLMM (#456)
  • [ ] Handle shear calibration and metadetect outputs
  • [ ] Use qp to interact with photoz

combet avatar Jan 19 '22 08:01 combet

Questions/Comments:

  • What do folks feel the scope of the minimal fitting module should be? I remember there being previous discussions on how much the fitting should rely on the user. But, if this is framed as a wrapper function within which folks can swap in/out their favorite fitter with 1-2 defaults, I could see this being useful.
  • [convener hat on] Can we define the CLMM v2.0 project, and can folks present this in the next CL General? :-)

cavestruz avatar Feb 03 '22 22:02 cavestruz

Initial suggestions from CLMM meeting for fitter:

  • Scipy optimizers (LGB....) specify box constraints instead of open ended paramaters, and set pseudo-priors (Angus)
  • emcee (can do things in parallel; all we need to provide is likelihood) - need to be able to do things like ensure that chains converged, etc. Note, can be tricky if we want automation - will require user to have more control. (Michel)

cavestruz avatar Feb 04 '22 15:02 cavestruz

Other points raised during the CLMM discussion:

  • Regarding MCMC, package like ChainConsumer is very useful to check properties of chains, convergence, etc. (Angus)
  • Modeling: allow for triaxial/ellipsoidal density profiles (Calum)
  • Covariance: we have covariance computed for a cluster ensemble, but might want to also include functionality for single cluster analysis (Constantin). (Also linked to that paper from Heidi)
  • Boost estimation:
    • Parametric implementation ongoing but how do we actually define the values of those parameters?
    • Calum: this is actually tricky and can be very dependent on photoz algorithm used
    • Michel: but can probably be infer from N(z) of the cluster versus background
    • Angus: only if you assume you have the true N(z), which we don't.
    • ...[Céline: not sure I've had all this conversation right, please edit accordingly @m-aguena, @calumhrmurray]
  • Interfacing with qp
    • qp will be the way photoz information is stored and pass around in DESC
    • ACTION ITEM: need to get in touch with qp folks and start adapting CLMM to handle photoz through qp

combet avatar Feb 04 '22 16:02 combet

Adding a new point to the list discussed above.

  • Shear calibration: we need to be able to handle metadetect outputs

combet avatar Feb 09 '22 09:02 combet

The previous comments cover what I had in mind. I add the following :

  • Would be nice to have methods to compute analytical covariances
  • The fitting module, using MCMC, is a “must have” for v2.2. As a user story, I want to be able to infer a posterior on the mass of an ensemble of clusters (and individual clusters), given a data vector containing the profiles + covariance.
  • Having a method to predict reduced shear profiles, given a cosmology, survey specifications (for the source sample) and cluster properties (redshift + observable). This would be the first brick for a forward modeling approach.

marina-ricci avatar Feb 11 '22 15:02 marina-ricci

Regarding the fitting module "must have", @vitenti just mentioned at the end of tag-up that the "connector" between FireCrown and CLMM is almost done, so we should be able to use FireCrown for this. Sandro, please correct me if I misunderstood.

combet avatar Feb 18 '22 16:02 combet

Oh and have CLMM pip-installable!

combet avatar Feb 21 '22 12:02 combet