CCL icon indicating copy to clipboard operation
CCL copied to clipboard

added clases dir with baryon halo model code

Open nikosarcevic opened this issue 10 months ago • 1 comments

nikosarcevic avatar Apr 19 '24 11:04 nikosarcevic

Pull Request Test Coverage Report for Build 8752817922

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.484%

Totals Coverage Status
Change from base Build 8354757719: 0.0%
Covered Lines: 6547
Relevant Lines: 6716

💛 - Coveralls

coveralls avatar Apr 19 '24 11:04 coveralls

@nikosarcevic can I get some context for this? I understand it's an attempt at a halo model for baryons in CCL, but from a birds eye view, none of the code lives where I would have expected it to (in the halo model module!).

damonge avatar Jun 18 '24 09:06 damonge

@nikosarcevic can I get some context for this? I understand it's an attempt at a halo model for baryons in CCL, but from a birds eye view, none of the code lives where I would have expected it to (in the halo model module!).

Hi, David

i can give an overview tomorrow in the ccl telecon. Bottom line: this works but it is incredibly slow (and it needs some additional checking/testing). I will get to it after I am done with my thesis. So we can pause/remove any merge for now. I am keeping the code on my branch.

nikosarcevic avatar Jun 18 '24 11:06 nikosarcevic

@nikosarcevic : ok, thanks for the explanation. I'll close the PR for now to avoid it taking space in our minds. Feel free to reopen whenever you think you'd like a review.

damonge avatar Jul 09 '24 22:07 damonge