CCL icon indicating copy to clipboard operation
CCL copied to clipboard

Inconsistent naming of BaccoEmu Baryons object

Open damonge opened this issue 2 years ago • 3 comments

The BaccoemuBaryons object should be called BaryonsBaccoemu to conform with the naming of other baryonic effect objects (e.g. BaryonsSchneider15 or BaryonsVanDaalen19).

Unfortunately this slipped through after tagging v3, and changing it would break the API. Thoughts?

damonge avatar Sep 28 '23 10:09 damonge

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

damonge avatar Sep 28 '23 10:09 damonge

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

I would suggest naming it "BaryonsArico20" to keep consistent with other modules.

nikosarcevic avatar Oct 02 '23 20:10 nikosarcevic

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

Do we need to create separate unit tests for the deprecated class?

zdu863 avatar Mar 27 '24 15:03 zdu863