BlendingToolKit
BlendingToolKit copied to clipboard
Added fixed aperture flux target measure
Closes #342
New target measure in the metrics module, for measuring the flux using a fixed circular aperture with sep.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Codecov Report
Base: 88.54% // Head: 87.89% // Decreases project coverage by -0.65%
:warning:
Coverage data is based on head (
4c4ec78
) compared to base (29e6564
). Patch coverage: 36.84% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 88.54% 87.89% -0.66%
===========================================
Files 11 11
Lines 1563 1578 +15
===========================================
+ Hits 1384 1387 +3
- Misses 179 191 +12
Flag | Coverage Δ | |
---|---|---|
unittests | 87.89% <36.84%> (-0.66%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
btk/metrics.py | 88.74% <36.84%> (-3.49%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
- fix pixel scale
- compare apeture flux photometry (sextractor vs scarlet), scatter plot
- documentation update
- change labels of figures
- (Maybe) true locations conditioned
I fixed the pixel scale issue and updated the doc ; I am merging this now and will open another PR for the plot (there are a few things I need to change, and I'll create a new notebook for reproducibility).