BlendingToolKit icon indicating copy to clipboard operation
BlendingToolKit copied to clipboard

Make metrics on tests more stable?

Open ismael-mendoza opened this issue 3 years ago • 3 comments

It's strange that the precision decrease from 0.5 to 0.25 even with different noise realizations. What do you think @thuiop ?

Originally posted by @ismael-mendoza in https://github.com/LSSTDESC/BlendingToolKit/pull/237#r739253386

ismael-mendoza avatar Oct 29 '21 13:10 ismael-mendoza

I repost my answer here :

Well the magnitude of the change is not abnormal, right now if there is one more or one less detection the value will change a lot. We should think about how to make this metric more useful.

thuiop avatar Oct 29 '21 16:10 thuiop

agreed - I didn't think it warranted holding up this issue much longer, thanks for your suggestion

ismael-mendoza avatar Oct 29 '21 16:10 ismael-mendoza

The solution is probably to make the test slower by having more sources. Not sure if this is a good idea.

ismael-mendoza avatar Feb 21 '22 01:02 ismael-mendoza

Test suite was changed by #412, metrics are now computed on aggregate over many batches on simple inputs so likely will always work otherwise something really wrong with algorithms implementation.

ismael-mendoza avatar Aug 13 '23 18:08 ismael-mendoza