MagiskOnWSALocal icon indicating copy to clipboard operation
MagiskOnWSALocal copied to clipboard

Fix install scripts

Open CarlGao4 opened this issue 1 year ago • 3 comments

  1. Use PowerShell 7 in higher priority
  2. Fix Get-WindowsOptionalFeature doesn't work when using PowerShell store version
  3. Chdir to current dir when starting cmd

Checklist

  • [ ] Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • [x] Have tested the modifications

CarlGao4 avatar May 01 '23 01:05 CarlGao4

Install or updating VCLibs will kill Windows Terminal, so we must start Powershell in ConHost.

Howard20181 avatar May 01 '23 01:05 Howard20181

Install or updating VCLibs will kill Windows Terminal, so we must start Powershell in ConHost.

Sorry to know that ...

CarlGao4 avatar May 01 '23 03:05 CarlGao4

@Howard20181 Please take a look now

CarlGao4 avatar May 01 '23 08:05 CarlGao4

I added -NoNewWindow to avoid terminals appear one by one... It's quite annoying for me.

CarlGao4 avatar May 17 '23 13:05 CarlGao4

I added -NoNewWindow to avoid terminals appear one by one... It's quite annoying for me.

Can you try again now? Which operation will cause the windows to open one by one?

Howard20181 avatar May 17 '23 13:05 Howard20181

I just explained why I added it 😃

CarlGao4 avatar May 17 '23 13:05 CarlGao4