lemur
lemur copied to clipboard
GenerateGUID shim should more obviously be constant or generate actual unique IDs
GenerateGUID doesn't actually generate a GUID--it gives a constant one. This is fine, but it's deceptive and looks random. I don't see a problem in changing it to something to where developers can easily tell its a shim (like 000000-...)
https://github.com/LPGhatguy/lemur/blob/ff37c3e486a2b6dec88abdeda52e6d0f5a7c06f4/lib/instances/HttpService.lua#L26
Funny, I just bumped into this myself.
When I added this, I didn't think too much about it, but you're absolutely right about it being misleading. I think the best solution would be to actually generate something unique so that anything that depends on generated ids will actually get different values.
+1 for "actually generate something unique so that anything that depends on generated ids will actually get different values"
Probably doesn't have to be anything complicated, a counter ticking up would probably work.