LOLBAS icon indicating copy to clipboard operation
LOLBAS copied to clipboard

Redundant/incorrect quotes in CL_LoadAssembly/UtilityFunction entries

Open oppiman opened this issue 3 years ago • 1 comments

First of all thank you all for the great work.

CL_LoadAssembly.ps1 uses a wrong quote char at the first position, and there should be no quote anyway. At the end there is a quote char missing.

”powershell.exe -command "set-location -path C:\Windows\diagnostics\system\Audio; import-module .\CL_LoadAssembly.ps1; LoadAssemblyFromPath ..\..\..\..\testing\fun.dll;[Program]::Fun()

UtilityFunctions.ps1 uses a wrong quote char at the end.

powershell.exe -command "set-location -path c:\windows\diagnostics\system\networking; import-module .\UtilityFunctions.ps1; RegSnapin ..\..\..\..\temp\unsigned.dll;[Program.Class]::Main()”

Maybe better to use the HTML codes everywhere.

oppiman avatar May 18 '22 08:05 oppiman

Thanks @oppiman, well spotted, you're right in both cases. Both issues were also identified in another pull request (#186) and have been fixed accordingly (cl_loadassembly.ps1, utilityfunctions.ps1). Hopefully this pull request gets merged soon.

wietze avatar May 18 '22 08:05 wietze