lnreader icon indicating copy to clipboard operation
lnreader copied to clipboard
verified publisher icon LNReader

Don't clean(cache) covers of entries added to the library

Open Palloxin opened this issue 2 years ago • 5 comments

Describe your suggested feature

When the cache gets cleaned covers of entries in the library disappear and require internet access to be seen again. So when there is no internet this the result and it is not good to see. IMG_20230701_101350

Instead make them not deletable by cache cleaning.

https://github.com/LNReader/lnreader/assets/75091899/2f8324f6-d347-4cdb-a2dd-87f8c496cd8e

In the video internet is turned off

Other details

Extension of this feature request:

To ensure that a cover can always be displayed, Lnreader should cache covers forever and only delete/change them if it can successfully download a new cover.

Why? For a reason or another covers can disappear from websites and if i have the previous cover already (entry in the library) DON'T delete it.

I made a similar F-R on the github of tachi that describes it in more detail, issue 9534.

EDIT: i just noticed that also the icon of sources disappear upon cache cleaning so same dynamic.

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • [X] I have written a short but informative title.
  • [X] If this is an issue with a source, I should be opening an issue in the sources repository.
  • [X] I have updated the app to version 1.1.14.
  • [X] I will fill out all of the requested information in this form.

Palloxin avatar Jul 01 '23 08:07 Palloxin

Is'nt it an expected behavior? Cleaning up cached covers then covers should be cleaned.

nyagami avatar Jul 03 '23 02:07 nyagami

Tachi already keeps covers of entries in the library(only them) even if the cache is cleared. It is like throwing away all your old socks before one buys new ones.

Palloxin avatar Jul 03 '23 07:07 Palloxin

Addition==> maybe it is related:

https://github.com/LNReader/lnreader/assets/75091899/97d0386f-92dc-4823-9936-ca992d1ebdfc

no internet. An entry in the library has the cover but when i click on it the cover doesnt exist. weird

Palloxin avatar Jul 05 '23 17:07 Palloxin

novel cover url in source hom screen and novel screen couldn't be the same

nyagami avatar Jul 09 '23 15:07 nyagami

This is the expected behaviour as the Covers and Source Icons in the app are stored in cache.

Instead make them not deletable by cache cleaning.

That would mean downloading covers for all the novels in library.

rajarsheechatterjee avatar Nov 11 '23 09:11 rajarsheechatterjee