lnreader icon indicating copy to clipboard operation
lnreader copied to clipboard

Set default TTS settings and add build script for Windows

Open bouchaala-sabri opened this issue 2 years ago • 4 comments

This PR sets the default TTS language to en-US and the default TTS voice to en-us-x-tpc-network for personal use. The network voice provides better quality than the offline voice. It also adds a new script for building the release on Windows.

Changes made:

  • Set default TTS language to en-US
  • Set default TTS voice to en-us-x-tpc-network
  • Add buildReleaseWin script for Windows users

The changes to the TTS settings were made for personal use, as the network voice provides better quality than the offline voice. The new buildReleaseWin script allows Windows users to easily build the release version of the app.

bouchaala-sabri avatar Apr 24 '23 09:04 bouchaala-sabri

But... there're users who dont read LN in English (included me)

nyagami avatar Apr 25 '23 10:04 nyagami

of course I'm aware of that, in fact, I can read Arabic and French my self but as I mentioned in the PR, I made these changes for my own selfish personal needs. 😄

In all seriousness, I had never developed anything for mobile or Android before. It took me two days just to figure out how to build the project. But it was worth it for me because the neural network voices are much better. In fact, the offline voice was so irritating that I couldn't stand to listen to it.

I decided to share this in case someone else needed it. And if there's anyone who can add a setting to choose the language and voices, that would be great.

I also tried to highlight the sentence being read and make the scroll follow the current sentence, but I wasn't able to do that.

On Tue, Apr 25, 2023, 11:42 AM nyagami @.***> wrote:

But... there're users who dont read LN in English (included me)

— Reply to this email directly, view it on GitHub https://github.com/LNReader/lnreader/pull/607#issuecomment-1521569567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6K7YUOA25M6LSAMOD7XTXC6TBTANCNFSM6AAAAAAXJJWTSY . You are receiving this because you authored the thread.Message ID: @.***>

bouchaala-sabri avatar Apr 25 '23 12:04 bouchaala-sabri

Hai,

thanks for the this PR. i total agree, offline voice is terrible. im really looking forward for this.

cd0rw0 avatar May 15 '23 04:05 cd0rw0

Everything you want is available in latest code

nyagami avatar Aug 17 '24 11:08 nyagami

Closing this as the features are now available in the master branch.

rajarsheechatterjee avatar Nov 04 '24 14:11 rajarsheechatterjee