LNReader
#1187 Add ability to disable chapter list navigation drawer swipe in reader
This PR fixes issue #1187 by adding a setting to disable the drawer swipe gesture.
Changes:
- Added a new setting "Disable drawer swipe navigation" in the reader settings
- The setting is enabled by default (drawer cannot be opened by swiping)
- The drawer can still be opened by tapping the button
- Swipe gestures for opening the drawer can be re-enabled through settings
This improves the reading experience for users who accidentally trigger the drawer while scrolling with their left hand, looking at you Jacubb.
What about a "Drawer swipe navigation" Instead of inverted logic? option turned off by default(drawer disabled), less confusing, no?
In my opinion the default for this feature should be disabled by default, as it isn't good to change the experience users are used too. Also I second to rename the open Drawer swipe navigation. The disable is unnecessary as the switch already conveys the meaning.
Alright, the default value of the setting is false now. Activating it, disables the drawer.
The toggle logic is still inverted, u just deleted the word disable. Expected behaviour: -toggle OFF: drawer disabled -toggle ON: drawer enabled
ON by default.
The current pr makes it inverted, that's a ‘inverted logic’
Current pr(inverted logic): ON: disabled drawer OFF: enabled drawer — Expected result: ON: enabled drawer OFF: disabled drawer — cough the inverted logic is still there.
ON: Drawer enabled OFF: Drawer disabled -‐------
And it is enabled/on by default?
https://github.com/user-attachments/assets/ff6bfd8b-ab83-4dff-bb89-be45ff9b4ff5
In the video the toggle is OFF, but tge drawer is enabled.
Expected: toggle ON, drawer enabled.
Yes, Enabled by default.
Thanks! Now the setting is on by default and the drawer is enabled. Deactivating the setting also disables the drawer.
This pr has conflicts, if you fix them now there is a high chance the main dev will merge it very quickly (it's a lucky period)