lnreader Faster & less laggy global search

memoise each row in the search results page
limit number of concurrent searches (has setting, defaults to 5 sources at once)
load sources in the same order as they show in menu so from the user's pov it loads in faster
Cancel search when u close global search
Made the order of sources that are still loading follow the sorted order so theres less popin
Added setting to remove animations from the loading placeholders
Pause global search if u open a sub window (eg opening a novel)
Change no results color to look less active

Sep 25 '24 09:09 Soopyboo32

Report. -Until bb57863 ("a") commit: https://github.com/Palloxin/lnreader-clone/actions/runs/11027091637 Lag disappeared except some flaws fixed later.

https://github.com/user-attachments/assets/f71b1422-80c4-44dd-b69d-e5956051dbd1

(clicked back button at "00:12") little lag(great)

-Until a6703c1 ("cancel search when..") commit: https://github.com/Palloxin/lnreader-clone/actions/runs/11031362148

https://github.com/user-attachments/assets/8b7c01f6-de22-4448-9964-b58311f0771c

(cant cancel global search due to super lag, first attempt at "00:16") The lag is back :( . Without animations is way better.

Sep 25 '24 11:09 Palloxin

dam, guess the animations are worse than i thought

Sep 25 '24 11:09 Soopyboo32

related: https://github.com/tomzaku/react-native-shimmer-placeholder/issues/91

Sep 25 '24 11:09 Soopyboo32

Report. commit c0675fd: The lag didnt go away.

https://github.com/user-attachments/assets/2d75df17-405a-4e99-9cf2-47b8afb8610e

Sep 25 '24 11:09 Palloxin

Report. commit a6fc3fd:

https://github.com/user-attachments/assets/7698b009-5862-4ef4-9abb-a20c59f00cb7

Browsing entries and plugins while global searching is.. laggy. Entries: a bit lag Plugins: lag

Pausing the global search upon these events would be best, if not nvm.

The pause is achieved on my part when I am away on another app. Somehow the app pauses global search in background (also while importing epubs, but that's another story)

Sep 26 '24 05:09 Palloxin

Would be possible to make No results found color a bit more "turned off"? Screenshot_20240926-094745_1

Sep 26 '24 07:09 Palloxin

There is a little problem when u trigger another global search while it's already global searching The blue progress bar doesnt reset, just continues. Probably other underlying things EDIT: well, even if u re-search after the end of a global search(without exiting the global search screen)

https://github.com/user-attachments/assets/93922b80-72e8-4f7f-b468-a5aca856c3ee

Oct 02 '24 21:10 Palloxin

Another bug, purely aeathetic, it's silly. Ignore if u like. If u split the screen while it's global searching, the blue progress bar will "reach" 100% graphycally. If you disable the split mode, it goes back on its place, no problem.

https://github.com/user-attachments/assets/05ea4696-f0d5-4277-9bcb-a53537a9e4f1

Oct 03 '24 21:10 Palloxin

Miscellaneous flaw. Search-keyword doesnt stay if u open an entry and then come back:

https://github.com/user-attachments/assets/6527d411-95ac-4162-a5e5-e74e88fe753f

Oct 10 '24 22:10 Palloxin

Flaw. Overlapping entry opening due to lag:

https://github.com/user-attachments/assets/e5d66a6d-87eb-47e6-9a61-7480774bd4e3

Due to lag, users might over click on an entry. This makes the app overlap the entries opening like in the video. A solution might be to prohibit the opening of more than one.

Oct 10 '24 23:10 Palloxin

I wont recommend removing skeleton loading

Oct 17 '24 03:10 nyagami

its still skeleton, just has no shimmer animation

https://youtu.be/gAqLgalEmh4

Oct 17 '24 04:10 Soopyboo32