lmms Revert #6883

Audio glitches from the SID instrument were recently reported (e.g. when using the "filter" option). Reverting #6883 fixes the issue. 6883 was originally needed because the original resid library we were using had naming conflicts with mingw-std-threads's mingw.condition_variable.h (allegedly, though I'm not seeing where the conflict would be in that file...), but since mingw-std-threads was removed, this is now a non-issue. Since 6883 now holds no purpose, reverting it is the simplest way to solve the audio glitch problem.

Sep 14 '25 21:09 sakertooth

Is the problem with libsidplayfp/resid a regression on their end? If so, maybe you could report it to their upstream bug tracker.

EDIT: Looks like they have a whole category for bugs related to the new 8580 filters: https://sourceforge.net/p/vice-emu/bugs/search/?q=_category:%22ReSID%20(new%208580%20filters)%22

Oct 06 '25 00:10 messmerd

Is the problem with libsidplayfp/resid a regression on their end? If so, maybe you could report it to their upstream bug tracker.

EDIT: Looks like they have a whole category for bugs related to the new 8580 filters: https://sourceforge.net/p/vice-emu/bugs/search/?q=_category:%22ReSID%20(new%208580%20filters)%22

I am not too sure. Kind of curious why the previous submodule behaved a bit more correctly than this one, but I can try to investigate it a bit more.

Oct 06 '25 10:10 sakertooth