Effect Author string discards all characters after "<"
System Information
Arch LInux, GNOME
LMMS Version(s)
master
Most Recent Working Version
No response
Bug Summary
The email addresses of effect authors are not visible in the effect browser, despite them being specified in the code. But it's not just email addresses, anything you put after a "<" will not show up in the final string.
Examples
Amplifier
Plugin::Descriptor PLUGIN_EXPORT amplifier_plugin_descriptor =
{
LMMS_STRINGIFY(PLUGIN_NAME),
"Amplifier",
QT_TRANSLATE_NOOP("PluginBrowser", "A native amplifier plugin"),
"Vesa Kivimäki <contact/dot/diizy/at/nbl/dot/fi>",
0x0100,
Plugin::Type::Effect,
new PluginPixmapLoader("logo"),
nullptr,
nullptr,
} ;
Compressor
Plugin::Descriptor PLUGIN_EXPORT compressor_plugin_descriptor =
{
LMMS_STRINGIFY(PLUGIN_NAME),
"Compressor",
QT_TRANSLATE_NOOP("PluginBrowser", "A dynamic range compressor."),
"Lost Robot <[email protected]>",
0x0100,
Plugin::Type::Effect,
new PluginPixmapLoader("logo"),
nullptr,
nullptr,
} ;
Random characters to test
Plugin::Descriptor PLUGIN_EXPORT oscilloscope_plugin_descriptor =
{
LMMS_STRINGIFY(PLUGIN_NAME),
"Oscilloscope",
QT_TRANSLATE_NOOP("PluginBrowser", "Oscilloscope plugin to display the incoming audio waveform"),
"Keratina<yayfhs 89 :) Keratin <[email protected]> hii",
0x0100,
Plugin::Type::Effect,
new PluginPixmapLoader("logo"),
nullptr,
nullptr,
} ;
Expected Behaviour
All characters in the author should be shown, including "<".
Steps To Reproduce
Press "Add Effect" on the mixer, and search for a native LMMS effect, and compare the author string to the one provided in the code.
Logs
Screenshots / Minimum Reproducible Project
No response
Please search the issue tracker for existing bug reports before submitting your own.
- [x] I have searched all existing issues and confirmed that this is not a duplicate.
OH I just realized why it's happening.
We use some kind of html-like language when creating the EffectSelectDialog, and </> are special characters.
Also for some reason Andy Wingo's email address is only partially cut off. It doesn't occur in 1.2.2, neither (or maybe partially) in a recent appimage build I have.
I think using QString::toHtmlEscaped in EffectSelectDialog::rowChanged may help
Hi! I'll attempt to fix this issue