lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Published 20 hours ago • verified publisher icon LMMS

WIP: new effect rack interface and features

Open enp2s0 opened this issue 9 months ago • 6 comments

This is still a heavy work-in-progress PR.

  • [x] Remove the broken gate knob
  • [ ] EffectView redesign
    • [x] Remove fixed-width pixmaps; support arbitrary widths; use QT layouts rather than fixed positioning
    • [x] Hide the decay knob if plugin auto quit is disabled
    • [x] Shrink vertical height of effects
    • [ ] Make EffectView respect theming options/colors
    • [x] Open effect UI by clicking on effect name a la SongEditor

enp2s0 avatar May 06 '24 20:05 enp2s0

It would be beneficial if you add screenshots here.

Rossmaxx avatar May 09 '24 06:05 Rossmaxx

I was requested as a reviewer but I am wondering if this PR is already ready for review? The title still says "WIP" and not all checkmarks are checked yet.

michaelgregorius avatar May 22 '24 18:05 michaelgregorius

Oops mb. Shouldn't have rushed the review call.

Rossmaxx avatar May 23 '24 03:05 Rossmaxx

I converted it to draft because it's a WIP. Change it back if it's ready.

Rossmaxx avatar May 29 '24 18:05 Rossmaxx

yes this is a WIP. Still working on it although I expect to have it wrapped up soon

enp2s0 avatar Jun 14 '24 18:06 enp2s0

If you don't mind, can you spin off the gate knob removal into it's own seperate Pull Request? Makes it easier to review

Rossmaxx avatar Jun 27 '24 12:06 Rossmaxx

Replaced by #7438.

enp2s0 avatar Aug 07 '24 16:08 enp2s0