lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Lv2 plugins with no outputs should be loadable

Open JohannesLorenz opened this issue 1 year ago • 1 comments

Enhancement Summary

Currently, a few of plugins will not load in LMMS, saying - no audio output channel (if you have LMMS_LV2_DEBUG set).

This is a missed opportunity, because those plugins could be used well.

Implementation Details / Mockup

As favored in discord, since LMMS requires to fill output buffers for all plugins, the solution is to let LMMS fill the output buffer with something sane in Lv2Proc::copyBuffersToCore, even if the plugin does not provide output via an output port. It has been agreed that in that case, the output buffer just shall mirror the values of the input buffer ("pass through").

An implementation must be careful so that for these plugins, the Lv2Proc::outPorts() function will never be called.

Please search the issue tracker for existing feature requests before submitting your own.

  • [X] I have searched all existing issues and confirmed that this is not a duplicate.

JohannesLorenz avatar Apr 03 '24 22:04 JohannesLorenz

This might have merge conflicts with #7387 , so waiting for that PR.

JohannesLorenz avatar Aug 04 '24 16:08 JohannesLorenz