lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Published 20 hours ago • verified publisher icon LMMS

Bad selection of colors on SF2 UI

Open musikBear opened this issue 2 years ago • 1 comments

Bug Summary

Visual impaired can see the settings for BANK & PATCH. Dark-purple on black is not functional

Steps to reproduce

Just look at it

Expected behavior

Clear and distinctable UI-text

Actual behavior

Not distinctable UI-text

Screenshot

image

Affected LMMS versions

< 1.2.

Type of Issue

Good fist Issue

musikBear avatar Jun 30 '22 16:06 musikBear

@musikBear: didn't you want to write "can't see"?

spechtstatt avatar Jul 23 '22 15:07 spechtstatt

@musikBear is this issue there with 1.3 alpha too or is this a nightly specific regression? I'm thinking of taking a shot at fixing the underlying issue so need more details. Also, don't have the alpha as i exclusively use the nightly.

Rossmaxx avatar Oct 01 '23 15:10 Rossmaxx

Pretty sure the box uses the file data/themes/default/lcd_21pink.png for the colours, so just increasing the brightness of the digits may be enough of a fix. The only places where this colour is currently used are Gigplayer and SF2, so there shouldn't be any issues with changing it.

DanielKauss avatar Oct 01 '23 15:10 DanielKauss

@DanielKauss thanks for the hint. I opened a pr (#6914) which will fix this issue.

Rossmaxx avatar Oct 02 '23 12:10 Rossmaxx

@musikBear is this issue there with 1.3 alpha too

Yes on my 1.3 image witch is image -Its old

musikBear avatar Oct 03 '23 14:10 musikBear

@musikBear can you take a look at the PR Rossmaxx opened, #6914, and tell us what you think of the color change?

Veratil avatar Oct 03 '23 15:10 Veratil

@musikBear can you take a look at the PR Rossmaxx opened, #6914, and tell us what you think of the color change?

image This is fine -Easy to read. Thanks!

musikBear avatar Oct 04 '23 15:10 musikBear

Deja vu... https://github.com/LMMS/lmms/pull/6474#issuecomment-1208904611

tresf avatar Oct 08 '23 00:10 tresf