lmms
lmms copied to clipboard
Add FFmpeg
Adds the FFmpeg library. Meant to replace sndfile in the future. Using FFmpeg comes with its own advantages, such as the support for a plethora of audio codecs and formats.
As the build shows, your PR fails the CI on all machines:
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:211 (message):
No REQUIRED_VARS specified for FIND_PACKAGE_HANDLE_STANDARD_ARGS()
Call Stack (most recent call first):
cmake/modules/FindFFmpeg.cmake:97 (find_package_handle_standard_args)
CMakeLists.txt:199 (FIND_PACKAGE)
I recommend making this PR a draft until you get it working.
:robot: Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! :tophat:
Linux
- Linux (AppImage):
lmms-1.3.0-alpha.1.186+g9dbe66fa1-linux-x86_64.AppImage(build link)
Windows
- Windows 32-bit:
lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win32.exe(build link) - Windows 64-bit:
lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win64.exe(build link)
:robot:
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/e183266e-22e7-40bf-95f1-fb015a1f489b/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/380?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/7fcc3270-3e3e-4f81-83dc-92502a2f3950/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/377?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/99c49b6e-c6ee-4c82-a75f-c4ff7d067821/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/378?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "9dbe66fa1afcbe54411f7f17d3a08c1b09b7bbe9"}
* Installing ffmpeg for MinGW should probably be moved to [`lmms-ci-docker`](https://github.com/LMMS/lmms-ci-docker) repository. I'll also ask @tobydox to create MinGW PPA packages for ffmpeg later.
Yeah, I figured that would be the best way to go about it but I realized tobydox didn't have FFmpeg packages in his PPA. To my surprise I thought I could get pre-built FFmpeg packages for MinGW somewhere else, but I suppose not.
Forgot to explain why I made this a draft over here.
I made this a draft because I'm waiting for @tobydox to add FFmpeg MinGW packages in his PPA. That way, we can move FFmpeg for MinGW to the docker images themselves without having to cross compile FFmpeg, as to which I'll adjust this PR accordingly. The "Install FFMpeg" step for Linux will also be moved to the docker images.