lmms icon indicating copy to clipboard operation
lmms copied to clipboard
verified publisher icon LMMS

Drag handle disappearance

Open Monospace-V opened this issue 3 years ago • 4 comments

Closest similar issue: https://github.com/LMMS/lmms/issues/6330 where it is mentioned the drag handle disappears sometimes.

Bug Summary

Drag handle disappears sometimes, on some specific projects. One of the triggers, in some cases, is renaming a track.

Steps to reproduce

1603bugcheck.zip Download the above zipped folder, and extract the file. It works only in 1.3 alpha.

  1. Open the Beat/Bassline editor.
  2. Rename any track there.

Expected behavior

Track gets renamed and track drag handles (dotted part of track for dragging) continue to stay visible

Actual behavior

Track gets renamed and track drag handles cease to exist

Screenshot

image Video:

https://user-images.githubusercontent.com/76674645/158777729-2d0a67b1-77a5-406a-9b8c-488764a753d1.mp4

Affected LMMS versions

1.3 alpha

This bug is tricky to reproduce in general, and easier to reproduce with the file.

Monospace-V avatar Mar 17 '22 09:03 Monospace-V

Bug confirmed. Some conditions should be met to reproduce this bug:

  • The editor must be able to be scrolled vertically
  • Enter/Return key should be pressed after renaming

bb_1 2 In 1.2, there is a small gap between the right edge of the window and the end of the note area.

bb_1 3 1.3 doesn't have such a gap.

I'm sure this is related to the bug, and the scroll area in TrackContainerView is somehow related.

PhysSong avatar Mar 19 '22 06:03 PhysSong

I found that #5102 caused the issue and also #6330. When the vertical scroll bar is visible, the width of TrackContainerView::m_scrollArea->widget() plus the width of the scroll bar becomes larger than the width of TrackContainerView, which make the scroll area vertically scrollable.

Note, if #5101 had been merged instead, this bug wouldn't happen. Instead, there will be a small visual artifact in the BB editor(now renamed to pattern editor):

https://user-images.githubusercontent.com/12591074/159111388-a5e6aa09-5e2c-4463-9995-f94c93053aee.mp4

PhysSong avatar Mar 19 '22 07:03 PhysSong

Instead, there will be a small visual artifact in the BB editor(now renamed to pattern editor)

One could argue that having the last step of the pattern hidden behind the scrollbar (current behavior) is an artifact.

allejok96 avatar Mar 22 '22 12:03 allejok96

There is no bug if song-editor is maximized. The bug only appear in windowed mode: image

musikBear avatar Mar 24 '22 18:03 musikBear