lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Reload stylesheet when CSS file changes

Open DomClark opened this issue 3 years ago • 4 comments

This PR is mostly just to get a CI build of this feature for a user on Discord, but maybe it could be useful? Does what it says on the tin. Will close if this isn't considered desirable/sufficiently useful.

DomClark avatar Mar 15 '22 00:03 DomClark

:robot: Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! :tophat:

Windows

Linux

macOS

:robot:
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://dl.circleci.com/private/output/job/75b565ae-e7fd-4ed4-9980-8eeedd7b4944/artifacts/0/lmms-1.3.0-alpha.1.175+g8dc097e40-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15923?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://dl.circleci.com/private/output/job/825bf1f0-2491-467a-a13e-54312dccd697/artifacts/0/lmms-1.3.0-alpha.1.175+g8dc097e40-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15924?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/g4anjjh399sxpgb6/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42897356"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/byvjjkyh2tkrnc08/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42897356"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://dl.circleci.com/private/output/job/82798282-9502-4480-8d00-a1afa7b3e62d/artifacts/0/lmms-1.3.0-alpha.1.175+g8dc097e40-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15925?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://dl.circleci.com/private/output/job/9beb114b-ce7a-4418-8159-0c115510a4e1/artifacts/0/lmms-1.3.0-alpha.1.175+g8dc097e40-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15926?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "baedf6865a9491e8a1f9aa77063d0696974a0f0e"}

LmmsBot avatar Mar 15 '22 01:03 LmmsBot

This is cool and IMHO definitely worth having, but for whatever reason when I change clip colors (in css) more than once they become gray. Newly created clips adopt the theme color, but any time the clip color is changed in css existing clips become gray again. The same doesn't happen for other elements as far as I can tell (tested mixer channel bg, mixer peak indicator, song editor background).

Spekular avatar Mar 15 '22 23:03 Spekular

A user on discord asked for a live theme editor and I got reminded about this PR existing (this PR is the closest thing to live theme editing). @DomClark is it possible to resolve the issue mentioned by spekular and bring this back?

If you are busy, feel free to avoid it. I felt like bumping because I don't want to see such small PRs gathering dust while it was supposed to be merged easily.

Rossmaxx avatar Jun 16 '24 12:06 Rossmaxx

... when I change clip colors (in css) more than once they become gray. Newly created clips adopt the theme color, but any time the clip color is changed in css existing clips become gray again.

I can't reproduce this, but I'm not sure whether it's due to something that's changed in master over the past two years, or whether I'm doing something wrong.

DomClark avatar Jun 21 '24 17:06 DomClark