lmms
lmms copied to clipboard
LMMS
Show error message when loading an invalid sample file
Fixes #6283.
It also fixes a bug that causes the sample clip view to disappear when trying to load an invalid file, although the clip still exists and it gets saved into the project. What actually happens is that the length of the clip is set to one bar when it is just created but it is set to zero when the file is invalid.
There is still an undesirable behavior: when trying to replace a valid sample file with an invalid one, the previous (valid) file disappears. It should be kept intact in this case. It seems quite complex to fix and is better left for another PR (issue: #6287).
:robot: Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! :tophat:
Windows
- Windows 32-bit:
lmms-1.3.0-alpha-msvc2017-win32.exe(build link) - Windows 64-bit:
lmms-1.3.0-alpha-msvc2017-win64.exe(build link)
:robot:
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/2qjl52xep12ajkqq/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43972180"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/m6t176idxv7f8qum/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43972180"}]}, "commit_sha": "d342666a75a5038b9fcb53e187d809bab63fceb6"}
The build generated by the boot crashes when loading a sample either in a sample track or as sample (tested on W10-64b)
@superpaik I have not experienced any crash on Linux. Have you tried the same sample on other PR builds?
Has any other user experienced a crash?
Yes, they work Ok on other PR. Can be due to the LmmsBot? It's weird that there is only the Win-MSVC version available.
@DomClark I assume with the changes requested fixed you'll approve now. @M374LX can you rebase on master and we can work on getting this merged finally. :)
