lmms icon indicating copy to clipboard operation
lmms copied to clipboard
verified publisher icon LMMS

Fix misalignment of knobs caused by wide labels

Open zynskeywolf opened this issue 4 years ago • 2 comments

This PR fixes the main cause of #5518. The positions are now recalculated when setting the label so that the knobs stay in place more or less. Also corrected the dirty compensations in builtin effects.

zynskeywolf avatar Mar 06 '21 13:03 zynskeywolf

:robot: Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! :tophat:

Linux

Windows

macOS

:robot: 
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12819-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fd-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12819?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12820-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fdbe-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12820?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12817-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fdbe-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12817?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/mjht54po6ony3bxc/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38093923"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/n5shlgniscx5a824/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38093923"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12816-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fdbe-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12816?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "ac5e36cbd1ea09087aa6eb8631663200c9c4fa53"}

LmmsBot avatar Mar 06 '21 13:03 LmmsBot

Knob internals were modified quite a bit in #7525. Mentioning this since it's relevant for future work on this PR.

rubiefawn avatar Oct 31 '25 00:10 rubiefawn