lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Upgrade libsndfile to 1.0.29

Open Spekular opened this issue 4 years ago • 10 comments

Issue #5128 was created by a bug in libsndfile, which is fixed in 1.0.29 (via this commit, I believe). This means #5501 can be reverted if we upgrade to libsndfile 1.0.29.

Spekular avatar Aug 16 '20 06:08 Spekular

This means #5501 can be reverted if we upgrade to libsndfile 1.0.29.

Yes, but it will take years for libsndfile 1.0.29 to be adopted. Ubuntu made their latest long-term support release in april this year and it will be maintained until 2025. We need to provide libsndfile ourselves in order to do this. It may not be worth the effort unless there are other issues we see that are fixed by this version as well.

zonkmachine avatar Aug 16 '20 14:08 zonkmachine

But surely that doesn't mean apt on LTS will be frozen with 2020 versions of everything until 2025? Or am I misunderstanding?

Spekular avatar Aug 16 '20 15:08 Spekular

But surely that doesn't mean apt on LTS will be frozen with 2020 versions of everything until 2025?

That is precisely what it means. Ubuntu are notoriously hard to convince to update to a newer version on any release, not only LTS. If they do, it will be in a special updates library that the user will have to change to manually and many are unwilling to do this. Remember how lmms-1.0.0 was rushed into a new Ubuntu stable but the package was accidentally borked? That haunted us for years. I see trouble ahead...

zonkmachine avatar Aug 16 '20 15:08 zonkmachine

Afternoon,

For ubuntu that can easily be fixed with a PPA

Regards, Jonathan

From: Oskar Wallgren [email protected] Sent: 16 August 2020 16:55 To: LMMS/lmms [email protected] Cc: Subscribed [email protected] Subject: Re: [LMMS/lmms] Upgrade libsndfile to 1.0.29 (#5633)

This means #5501https://github.com/LMMS/lmms/pull/5501 can be reverted if we upgrade to libsndfile 1.0.29.

Yes, but it will take years for libsndfile 1.0.29 to be adopted. Ubuntu made their latest long-term support release in april this year and it will be maintained until 2025. We need to provide libsndfile ourselves in order to do this. It may not be worth the effort unless there are other issues we see that are fixed by this version as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/LMMS/lmms/issues/5633#issuecomment-674536450, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACX4MANQIJ2JJ5C4TKQIHTSA7XMPANCNFSM4QAVRD2Q.

eagles051387 avatar Aug 17 '20 12:08 eagles051387

For ubuntu that can easily be fixed with a PPA

And you think we should do that for an issue that already has a workaround? I suggest we do nothing and bump the topic some four years from now.

zonkmachine avatar Aug 17 '20 14:08 zonkmachine

We could perhaps test libsndfile version and do:

clipvalue = -1.0f

If it's >=1.0.29 ?

http://www.mega-nerd.com/libsndfile/command.html#SFC_GET_LIB_VERSION

zonkmachine avatar Aug 11 '21 10:08 zonkmachine

update?

Rossmaxx avatar Oct 22 '23 12:10 Rossmaxx

update?

Debian, Ubuntu, Fedora, whatever distros are most used. Just look at their latest stable releases and see what version of libsndfile they provide.

zonkmachine avatar Oct 22 '23 13:10 zonkmachine

Looked it up on repology, unfortunately, 1.0.32 is available on ubuntu 22.04 but everything before that is stuck with 1.0.28

Rossmaxx avatar Apr 22 '24 06:04 Rossmaxx

Great! Then it will be solved around 26.04 . Let's add a year of margin, so we solve this around 27.04. Bump me then and not before. It's not really an issue if you consider that it's a bit that is gone from the absolute loudest signals and most signals don't clip.

zonkmachine avatar Apr 22 '24 06:04 zonkmachine