lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Add "natural" scrolling support for trackpads

Open tresf opened this issue 5 years ago • 8 comments

Adds QWheelEvent::inverted() support to LcdSpinbox, Knob.

Closes #5507

~~If desired, may be a candidate for backport to 1.2.0 with a cherry-pick.~~

Edit: On second thought, let's let 1.2.x drift into the archives of time. master master race. :D

tresf avatar May 21 '20 16:05 tresf

:robot: Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! :tophat:

Linux

Windows

macOS

:robot:
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://6593-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.681-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6593?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://6594-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.681-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6594?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://6592-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.681-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6592?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/jjlwe73x61njxyw0/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/33032761"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/yw1ok0tr653x47b2/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/33032761"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://6591-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.681-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6591?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "0ced133065f1145e6d3bb7a6480fe2606158edb9"}

LmmsBot avatar May 21 '20 16:05 LmmsBot

LGTM. This looks fine for 1.2.2

zonkmachine avatar May 23 '20 13:05 zonkmachine

FYI, you will find some more places if you git grep for delta().

PhysSong avatar May 27 '20 01:05 PhysSong

FYI, you will find some more places if you git grep for delta().

Thanks. Can we work from an exhaustive list then? (PLEASE EDIT!)

File Needs Flip Done
src/gui/editors/AutomationEditor.cpp ✅(excluding horizontal scroll) 🚫 Not sure where 🤦
src/gui/editors/PianoRoll.cpp ✅(note panning)
src/gui/editors/SongEditor.cpp ✅(excluding horizontal scroll)
src/gui/widgets/ComboBox.cpp
vsrc/gui/widgets/Fader.cpp
src/gui/widgets/Knob.cpp
src/gui/widgets/LcdSpinBox.cpp
src/gui/widgets/TabWidget.cpp ✖️(no, but could use proper card-swipe support) 🚫 Works as-is, but too sensitive and no left/right scroll support
src/tracks/Pattern.cpp ✅(Velocity for beat/bassline editor) ✅ It's not in Pattern.cpp, but tackled in MidiClipView .

I'm not sure about where the delta() is used for some of the editors. If it's scrubbing/scroll bars, that's behaving properly, but I notices that note panning on Piano Roll needs it so I might be missing something.

tresf avatar May 27 '20 16:05 tresf

@tresf Merging this already (I think you can merge in CLI and still keep the PR open) might reduce merge conflicts after reorg. It's also useful to have it working for the most important widgets, so maybe get this code to master?

JohannesLorenz avatar Jan 13 '21 20:01 JohannesLorenz

@tresf Merging this already (I think you can merge in CLI and still keep the PR open) might reduce merge conflicts after reorg. It's also useful to have it working for the most important widgets, so maybe get this code to master?

The code will be trivial to rebase. @PhysSong's instincts were to do this one for most items and I don't hate that idea. I'll move it to a WIP PR because it will require work before its ready.

tresf avatar Jan 13 '21 20:01 tresf

Table updated https://github.com/LMMS/lmms/pull/5510#issuecomment-634779554. Ready for review.

tresf avatar May 09 '24 06:05 tresf

The minimum qt version is now 5.9 so this check is obsolete now.

Removed checks.

tresf avatar May 09 '24 07:05 tresf