Splash screen hides child windows

[tresf]

There are several times opening LMMS on various platforms where the splash screen was on top of a subwindow.

Here's an example on MacOS

The splash screen should not be "always on top" as it can hide important messages.

[tresf]

I think we can simply do...

--- a/src/gui/GuiApplication.cpp
+++ b/src/gui/GuiApplication.cpp
@@ -86,6 +86,7 @@ GuiApplication::GuiApplication()
 
        // Show splash screen
        QSplashScreen splashScreen( embed::getIconPixmap( "splash" ) );
+       splashScreen.setWindowFlags( splashScreen.windowFlags() & ~Qt::WindowStaysOnTopHint );
        splashScreen.show();
 
        QHBoxLayout layout;

... however I'm having a hard time reproducing this pop-up window now for a baseline test.

[zonkmachine]

Related: https://github.com/LMMS/lmms/issues/1882

[zonkmachine]

... however I'm having a hard time reproducing this pop-up window now for a baseline test.

I'm testing this now and it works fine but like you I can't reproduce the issue. Ubuntu used to hit me with windows on top of each other ten years ago or so but I can't remember that happen in the last two years. At all. I think you should just add this in there and lay it on the users to find out if it works or not.

[zonkmachine]

Possible relate Qt issue: https://bugreports.qt.io/browse/QTBUG-49576 (it differs from our issue by being specifically on macos)

As suggested by @tresf in this comment https://github.com/LMMS/lmms/issues/1882#issuecomment-83011170

Provide a new --nosplash command line option

That's an idea that reasons with me. There also was suggested somewhere, can't find a reference to the idea now, to introduce a --failsafe command line argument. In my mind this option could turn off the splash screen, load an empty.mpt, load the default theme, etc. That would help softening the blow a bit as we provide a workaround, but it isn't a fix.

I'm removing this from 1.3