performances issue
Description of Bug
hey there seems to be a performance issue on quests since its taking a lot of server ticks
here is the sparlk link https://spark.lucko.me/khjiZcxmtl
Steps to Reproduce
check my spark here , there is 100 players online
Environment
- Minecraft version: 1.17.1. pufferfish
- Server software: r9 5950x 128 Gb of ram
- Quests version: latest
Agreements
- [X] I am running the latest version of Quests
- [X] I am certain this issue is unique and a similar issue is not currently open
- [X] I am using a version of Minecraft which is supported by Quests
Other
No response
@LMBishop
Do you have the quests debugger enabled?
i don't see any debuger on the config here is mine https://pastebin.com/An1Czhz5
Do you have the quests debugger enabled?
@LMBishop
@LMBishop please can you look into it its taking 10% of my server ticks which is dumb for a quest plugin i aslo have no debug on config as you can see above
https://spark.lucko.me/dk5vi9DdRx
or maybe @Krakenied
https://github.com/LMBishop/Quests/actions/runs/3665611511 This build should fix your issue.
https://github.com/LMBishop/Quests/actions/runs/3665611511 This build should fix your issue.
thats amazing now quests only show under wildstacker hook is this already optimized or can be more ? https://spark.lucko.me/vC9779FPke
We can make debug logging async but I'm not sure about it. Alternatively we probably can kinda rework that system and iterate only over players who have enabled debug (atm we iterate over all loaded players).
^ did some micro opts but I think it won't help much https://github.com/LMBishop/Quests/actions/runs/3679637272