sundials
sundials copied to clipboard
API inconsistency: some SUNDIALS "Space" functions use `sunindextype` and some use `long int`
For example, we have
N_VSpace(N_Vector x, sunindextype *lenrw, sunindextype *leniw);
SUNMatSpace(SUNMatrix A, long int *lenrw, long int *liniw);
This is sort of related to conversation in #409. We use long
in many places where we should now switch to either long long
or a fixed-width type like int64_t
since we are now requiring C99. However, in this case I think we want to use sunindextype
.
The use of sunindextype
in N_VSpace
was an erroneous change when sunindextype
was added. It would be good to address in 7.0 (at least for consistency).
Looks like sunindextype
is used for ARKodeButcherTable_Space
too.
This was fixed in 7.0
Actually, I was mistaken, this was not fixed in 7.0.0