serac icon indicating copy to clipboard operation
serac copied to clipboard

WIP: Update Sundials

Open white238 opened this issue 3 months ago • 2 comments

  • Updates SUNDIALS past 7.0
  • Calls new MFEM Sundials Finalize to avoid calling MPI after our MPI_Finalize due to previous RAII static destructor logic

This cannot be merged until https://github.com/mfem/mfem/pull/5073 goes into MFEM. Thanks @balos1 !

white238 avatar Oct 14 '25 23:10 white238

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.03%. Comparing base (db9409c) to head (c5366c9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1482   +/-   ##
========================================
  Coverage    92.03%   92.03%           
========================================
  Files          199      200    +1     
  Lines        25212    25221    +9     
========================================
+ Hits         23203    23212    +9     
  Misses        2009     2009           
Flag Coverage Δ
unittests 92.03% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 15 '25 05:10 codecov-commenter

I'll clean this up after the other PR merges and i update MFEM with Cody's fix. Ignore for now.

white238 avatar Oct 16 '25 00:10 white238

succeeded by https://github.com/llnl/smith/pull/1509

chapman39 avatar Dec 30 '25 23:12 chapman39