libROM icon indicating copy to clipboard operation
libROM copied to clipboard

Published 20 hours ago • verified publisher icon LLNL

Fix dg_euler build

Open dylan-copeland opened this issue 10 months ago • 1 comments

MFEM PR 3598 was recently merged to the MFEM master branch, refactoring ex18(p). One change that causes build issues with libROM is that class RiemannSolver and some other classes were moved from the example to the library, in mfem/fem/hyperbolic.hpp. As a result, libROM fails to build with the latest MFEM. There are significant changes in MFEM, beyond just moving some classes to the library. Properly fixing dg_euler may take some careful work. In the meantime, to fix the build immediately, I simply renamed the classes in dg_euler.hpp with the prefix ROM_, to avoid ambiguity.

dylan-copeland avatar Apr 26 '24 18:04 dylan-copeland

We need 1 more approval to fix the broken libROM build. @chldkdtn @siuwuncheung @dreamer2368

dylan-copeland avatar May 07 '24 02:05 dylan-copeland