libROM icon indicating copy to clipboard operation
libROM copied to clipboard

Published 20 hours ago • verified publisher icon LLNL

Hard-coded values in NNLS solver

Open dreamer2368 opened this issue 1 year ago • 0 comments

Line 66 and 163 of lib/linalg/NNLS.cpp use hard-coded values of n_proc_max_for_partial_matrix_ = 15 and nb = 3, which seem to be used mainly for distributing the matrix.

  • There is no sufficient description as to why these values are chosen.
  • For better scalability of this solver, shouldn't these values be determined by the users?

dreamer2368 avatar Feb 13 '24 06:02 dreamer2368