libROM icon indicating copy to clipboard operation
libROM copied to clipboard

`Matrix::orthogonalize()` works only for distributed case.

Open dreamer2368 opened this issue 1 year ago • 1 comments

Based on the definition in lib/linalg/Matrix.cpp, void Matrix::orthogonalize() works only when the matrix is distributed (in parallel case). It should have a line:

CAROM_VERIFY(distributed());

dreamer2368 avatar Jul 29 '23 01:07 dreamer2368

@dreamer2368 Can you elaborate on this?

I'm working on PR #239 which solves a bug in the orthogonalize() method and adds an incremental method orthogonalize_last(). The PR also includes unit tests for those methods which run successfully for non-distributed matrices.

Do those changes solve the issue you're referring to here?

cval26 avatar Sep 28 '23 19:09 cval26