libROM icon indicating copy to clipboard operation
libROM copied to clipboard

Published 20 hours ago • verified publisher icon LLNL

gLaSDI update

Open xiaolong7 opened this issue 2 years ago • 1 comments

Converted notebook to Python scripts Updated README Corrected typos in src/error_utils.py

xiaolong7 avatar Jun 22 '22 16:06 xiaolong7

@dylan-copeland @siuwuncheung @kevinhkhuynh where are we with this PR? Do we have enough review for this PR?

chldkdtn avatar Jul 22 '22 22:07 chldkdtn

@xiaolong7 Is this PR still in a ready-for-review state, given the recent changes?

pranav-vempati avatar Jan 14 '23 00:01 pranav-vempati

@xiaolong7 Is this PR still in a ready-for-review state, given the recent changes?

Yes, it is ready for review.

xiaolong7 avatar Jan 14 '23 05:01 xiaolong7

@xiaolong7 I am going to close this PR because we have gLaSDI repo in a separate repo. Is it okay?

chldkdtn avatar May 03 '23 04:05 chldkdtn

Fine with me!

On Tue, May 2, 2023, 9:10 PM Youngsoo Choi @.***> wrote:

@xiaolong7 https://github.com/xiaolong7 I am going to close this PR because we have gLaSDI repo in a separate repo. Is it okay?

— Reply to this email directly, view it on GitHub https://github.com/LLNL/libROM/pull/126#issuecomment-1532435299, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPYY6UTEFLKPLIAULCX6G3XEHLCNANCNFSM5ZQ6PGQA . You are receiving this because your review was requested.Message ID: @.***>

jtlau avatar May 03 '23 04:05 jtlau

Closing this PR because we have public gLaSDI repo at https://github.com/LLNL/gLaSDI

chldkdtn avatar May 07 '23 05:05 chldkdtn